corestack/go
2
0 Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

feat(lifecycle/cli): run native commands with selected modules #16

Merged
end merged 4 commits from feat/lifecycle-cli into main 2026-10-28 14:46:11 -07:00
Conversation 0 Commits 4 Files Changed 7
+837
end commented 2026-10-28 14:36:32 -07:00
Owner
Copy link
Copy source

Add lifecycle/cli with Run(ctx, cliRoot, args) (int, error), Serve, and Action for native urfave/cli commands, flags and help. Explicit module selections reuse lifecycle setup, reverse cleanup and bounded shutdown; one-offs suppress services, and nil signal channels get a temporary owned subscription. No managed-worker API or reusable migration CLI (#9) is included.

Pin urfave/cli v3.14.0 in the root module: its production imports use only the standard library, so this small dependency fits the accepted module boundary. Owner-accepted native environment/custom-validation and generated-help parse failures remain code 1; malformed generated help can emit native plus adapter diagnostics.

Merge readiness: independent standard (gpt-6.1-sol medium) and fresh high (gpt-6.1-sol high) reviews of e0673630d5876ece6f2419b4b63ce9f643d5a082 found zero Blocking/Major/Minor issues. Implementer evidence records build, vet, race tests, pinned lint (0 issues), docs (5 records), TODO and formatting checks passing; local PostgreSQL tests skipped without DSNs. Reconciled against latest main f0439000cbed0ffdccad0521748bcf1738af4a0c; final head 79e28eb9a6db38a5c1cb3e8b745dfdc1ae8b3587 adds only ADR publication metadata (5 additions/4 deletions), verified with docs check and diff checks. Final-head CI passed: ci/check (format, vet, full race tests with required PostgreSQL integrations, TODO, lint, GoReleaser check and snapshot) and Documentation/docs. No outstanding review findings; ready for owner merge review. Not merged or deployed.

Closes #8

Add `lifecycle/cli` with `Run(ctx, cliRoot, args) (int, error)`, `Serve`, and `Action` for native urfave/cli commands, flags and help. Explicit module selections reuse lifecycle setup, reverse cleanup and bounded shutdown; one-offs suppress services, and nil signal channels get a temporary owned subscription. No managed-worker API or reusable migration CLI (#9) is included. Pin urfave/cli v3.14.0 in the root module: its production imports use only the standard library, so this small dependency fits the accepted module boundary. Owner-accepted native environment/custom-validation and generated-help parse failures remain code 1; malformed generated help can emit native plus adapter diagnostics. Merge readiness: independent standard (gpt-6.1-sol medium) and fresh high (gpt-6.1-sol high) reviews of `e0673630d5876ece6f2419b4b63ce9f643d5a082` found zero Blocking/Major/Minor issues. Implementer evidence records build, vet, race tests, pinned lint (0 issues), docs (5 records), TODO and formatting checks passing; local PostgreSQL tests skipped without DSNs. Reconciled against latest main `f0439000cbed0ffdccad0521748bcf1738af4a0c`; final head `79e28eb9a6db38a5c1cb3e8b745dfdc1ae8b3587` adds only ADR publication metadata (5 additions/4 deletions), verified with docs check and diff checks. Final-head CI passed: [ci/check](https://gitea.auvem.com/corestack/go/actions/runs/2712/jobs/3323) (format, vet, full race tests with required PostgreSQL integrations, TODO, lint, GoReleaser check and snapshot) and [Documentation/docs](https://gitea.auvem.com/corestack/go/actions/runs/2713/jobs/3324). No outstanding review findings; ready for owner merge review. Not merged or deployed. Closes #8
end added 3 commits 2026-10-28 14:36:32 -07:00
docs(adr): propose native lifecycle CLI contract 23dfb6d956
docs(adr): clarify native CLI errors and compatibility 1b7565113c
feat(lifecycle/cli): run native commands inside selected modules
Documentation / docs (pull_request) Successful in 17s
Details
ci / check (pull_request) Successful in 4m1s
Details
e0673630d5
end added 1 commit 2026-10-28 14:36:43 -07:00
docs(adr): record lifecycle CLI publication and review evidence
Documentation / docs (pull_request) Successful in 23s
Details
ci / check (pull_request) Successful in 3m59s
Details
79e28eb9a6
end merged commit fe44cac3a2 into main 2026-10-28 14:46:11 -07:00
end deleted branch feat/lifecycle-cli 2026-10-28 14:46:11 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
end (Elijah Duffy) selias (Sebastian Elias)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: corestack/go#16