1.1.0

package.json

@@ -4,7 +4,7 @@
 		"type": "git",
 		"url": "https://gitea.auvem.com/svelte-toolkit/sui.git"
 	},
-	"version": "1.1.1",
+	"version": "1.1.0",
 	"scripts": {
 		"dev": "vite dev",
 		"build": "vite build && pnpm run prepack",

src/lib/Combobox.svelte

@@ -247,6 +247,7 @@
 				highlighted = value; // reset highlighted item to current value
 			}
 
+			console.log('combobox open', isOpen);
 			onopenchange?.(isOpen);
 		}
 	});

src/lib/Dialog.svelte

@@ -5,8 +5,6 @@
 	export interface DialogAPI {
 		/** shows an error message at the top of the dialog */
 		error: (message: RawError | null) => void;
-		/** Returns if the dialog is displaying an error */
-		hasError: () => boolean;
 		/** closes the dialog */
 		close: () => void;
 		/** opens the dialog */
@@ -41,8 +39,6 @@
 		 * changes made via this API will NOT propagate to consuming components.
 		 */
 		title: (title: string) => void;
-		/** Focuses the dialog */
-		focus: () => void;
 	}
 
 	type DialogControlButton = {
@@ -83,9 +79,6 @@
 	};
 
 	export { dialogCancelButton, dialogOkButton, dialogCloseButton };
-
-	/** stack of currently open dialogs by identifier */
-	let dialogStack: DialogAPI[] = $state([]);
 </script>
 
 <script lang="ts">
@@ -98,7 +91,7 @@
 	import { X } from 'phosphor-svelte';
 	import { ErrorMessage, type RawError } from './error';
 	import ErrorBox from './ErrorBox.svelte';
-	import { generateIdentifier, mergeOverrideObject } from './util';
+	import { mergeOverrideObject } from './util';
 
 	interface Props {
 		/** Bindable open state of the dialog */
@@ -119,18 +112,10 @@
 		controlsAlign?: 'start' | 'center' | 'end';
 		/** Top-right close control */
 		close?: Snippet | Omit<DialogControlButton, 'label'> | null;
-		/**
-		 * Callback when the dialog is opened
-		 * @deprecated use onopenchange instead and check the open parameter
-		 */
+		/** Callback when the dialog is opened */
 		onopen?: (dialog: DialogAPI) => void;
-		/**
-		 * Callback when the dialog is closed
-		 * @deprecated use onopenchange instead and check the open parameter
-		 */
+		/** Callback when the dialog is closed */
 		onclose?: (dialog: DialogAPI) => void;
-		/** Callback when the dialog open state changes */
-		onopenchange?: ({ open, dialog }: { open: boolean; dialog: DialogAPI }) => void;
 		/** If default controls are used, controls loading state of submit button */
 		loading?: boolean;
 		/** If default controls are used, freezes all interactions */
@@ -151,68 +136,34 @@
 		close = {},
 		onopen,
 		onclose,
-		onopenchange,
 		loading = $bindable(false),
 		frozen = $bindable(false),
 		disabled = $bindable(false)
 	}: Props = $props();
 
-	const controls = $derived(
+	let controls = $derived(
 		typeof rawControls === 'function'
 			? rawControls
 			: mergeOverrideObject(defaultDialogControls, rawControls)
 	);
 
-	const identifier = generateIdentifier('dialog');
-
-	let lastOpen = $state(open);
-	let dialogPage = $state<HTMLDivElement | null>(null);
 	let dialogContainer = $state<HTMLDivElement | null>(null);
 	let error = $state<ErrorMessage | null>(null);
-	let stackIndex = $state(-1);
 
-	/** handles open change */
-	const handleOpenChange = (localOpen: boolean) => {
-		if (localOpen) {
-			document.body.style.overflow = 'hidden'; // prevent scrolling
-			// focus the dialog BEFORE callbacks for accessibility & flexibility
-			dialogPage?.focus();
-			// run callbacks
-			onopen?.(dialogAPI);
-			onopenchange?.({ open: true, dialog: dialogAPI });
-			//update stack
-			dialogStack.push(dialogAPI); // add to stack of open dialogs
-			stackIndex = dialogStack.length - 1; // track index in stack for this dialog
-		} else {
-			// update stack
-			dialogStack.pop(); // remove from stack of open dialogs
-			stackIndex = -1; // reset stack index for this dialog
-			// update focus & handle scroll locking for accessibility
-			if (dialogStack.length > 0) {
-				dialogStack[dialogStack.length - 1].focus();
-			} else {
-				document.body.style.overflow = ''; // re-enable scrolling since no dialogs are open
-			}
-			// run callbacks
-			onclose?.(dialogAPI);
-			onopenchange?.({ open: false, dialog: dialogAPI });
-		}
-	};
-
-	// deduplicate open changes
+	// disable window scroll when dialog is open
 	$effect(() => {
-		if (open !== untrack(() => lastOpen)) {
-			lastOpen = open;
-			untrack(() => {
-				handleOpenChange(open);
-			});
+		if (open) {
+			document.body.style.overflow = 'hidden';
+			untrack(() => onopen?.(dialogAPI));
+		} else {
+			document.body.style.overflow = '';
+			untrack(() => onclose?.(dialogAPI));
 		}
 	});
 
 	/** DialogAPI instance to control this dialog */
 	export const dialogAPI: DialogAPI = {
 		error: (message) => (error = ErrorMessage.from(message)),
-		hasError: () => error !== null,
 		close: () => (open = false),
 		open: () => (open = true),
 		isOpen: () => open,
@@ -226,8 +177,7 @@
 		unfreeze: () => (frozen = false),
 		isFrozen: () => frozen,
 		canContinue: () => !loading && !disabled && !frozen,
-		title: (newTitle) => (title = newTitle),
-		focus: () => dialogPage?.focus()
+		title: (newTitle) => (title = newTitle)
 	};
 
 	/** Returns the current state of the dialog */
@@ -249,14 +199,11 @@
 
 {#snippet dialog()}
 	<div
-		bind:this={dialogPage}
 		class={[
-			'fixed inset-0 flex items-center-safe justify-center bg-black/50 backdrop-blur-sm',
+			'fixed inset-0 z-50 flex items-center-safe justify-center bg-black/50 backdrop-blur-sm',
 			'overflow-auto p-8',
 			classValue
 		]}
-		style={// increase z-index and decrease opacity for each nested dialog
-		`z-index: ${1000 + stackIndex}`}
 		transition:fade={{ duration: 150 }}
 		onclick={(e) => {
 			const target = e.target as HTMLElement;
@@ -265,15 +212,10 @@
 		}}
 		onkeydown={(e) => {
 			if (e.key === 'Escape' && !frozen) {
-				if (stackIndex === dialogStack.length - 1) {
-					// only close if this dialog is the topmost dialog
-					open = false;
-				}
+				open = false;
 			}
 		}}
 		role="dialog"
-		aria-labelledby="{identifier}-title"
-		aria-describedby="{identifier}-description"
 		tabindex="-1"
 	>
 		<div
@@ -293,10 +235,7 @@
 		>
 			<div class="flex items-center justify-between">
 				<!-- Dialog title -->
-				<h2
-					class="pointer-events-none mb-2 text-lg font-medium text-black select-none"
-					id="{identifier}-title"
-				>
+				<h2 class="pointer-events-none mb-2 text-lg font-medium text-black select-none">
 					{@render stringOrSnippet(title)}
 				</h2>
 
@@ -315,7 +254,7 @@
 			{/if}
 
 			{#if description}
-				<p class="mb-3 leading-normal text-zinc-600" id="{identifier}-description">
+				<p class="mb-3 leading-normal text-zinc-600">
 					{@render stringOrSnippet(description)}
 				</p>
 			{/if}

src/routes/+page.svelte

@@ -35,7 +35,8 @@
 	import { createLazyComponent, type ComboboxOption, type Option } from '$lib';
 	import Tabs from '$lib/Tabs.svelte';
 	import { Time } from '@internationalized/date';
-	import { onMount } from 'svelte';
+	import { onMount, type Component } from 'svelte';
+	import ErrorBox from '$lib/ErrorBox.svelte';
 	import TextareaInput from '$lib/TextareaInput.svelte';
 	import DurationInput, { formatDuration } from '$lib/DurationInput.svelte';
 	import Banner from '$lib/Banner.svelte';
@@ -59,7 +60,6 @@
 	let dateInputValue = $state<CalendarDate | null>(null);
 	let checkboxValue = $state<CheckboxState>('indeterminate');
 	let dialogOpen = $state(false);
-	let nestedDialogOpen = $state(false);
 	let scrollableDialogOpen = $state(false);
 	let toggleOptions: Option[] = $state([
 		'item one',
@@ -218,7 +218,7 @@
 			label="Lazy combobox"
 			placeholder="Choose..."
 			options={lazyOptions}
-			lazy="always"
+			lazy={'always'}
 			onlazy={async () => {
 				await new Promise((resolve) => setTimeout(resolve, 2500));
 				lazyOptions = [
@@ -555,13 +555,6 @@
 	}}
 >
 	<p>This is a dialog content area.</p>
-
-	<Button onclick={() => (nestedDialogOpen = true)}>Open Nested Dialog</Button>
-</Dialog>
-
-<!-- Nested Dialog Demo -->
-<Dialog bind:open={nestedDialogOpen} title="Nested Dialog" size="sm">
-	<p>This is a nested dialog content area.</p>
 </Dialog>
 
 <!-- Scrollable Dialog Demo -->