add logs at start, end, and errors

python/packages/server/src/officeconvert_server/service.py

@@ -5,9 +5,11 @@ from __future__ import annotations
 import asyncio
 from collections.abc import Callable
 from datetime import datetime, timedelta, timezone
+import logging
 from pathlib import Path
 import shutil
 import tempfile
+import time
 import uuid
 
 from connectrpc.code import Code
@@ -16,6 +18,7 @@ from connectrpc.request import RequestContext
 from google.protobuf.timestamp_pb2 import Timestamp
 from officeconvert import SlideArtifact, convert_pptx_to_slidedeck
 from officeconvert.conversion import (
+    ConversionTimeoutError,
     PHASE_EXTRACTING_NOTES,
     PHASE_PDF_TO_IMAGES,
     PHASE_PPTX_TO_PDF,
@@ -26,6 +29,8 @@ from officeconvert_server.config import ServerConfig
 from officeconvert_server.models import ConversionSession, utc_now
 from officeconvert_server.storage import S3Store
 
+logger = logging.getLogger("uvicorn.error")
+
 
 class ConversionServiceImpl(conversion_connect.ConversionService):
     """Implements the conversion API with in-memory state and S3 orchestration."""
@@ -179,6 +184,16 @@ class ConversionServiceImpl(conversion_connect.ConversionService):
 
     async def _run_conversion(self, session: ConversionSession) -> None:
         """Execute conversion flow and persist terminal state in memory."""
+        started_at = time.monotonic()
+        logger.info(
+            "Starting conversion conversion_id=%s source_filename=%s dpi=%d "
+            "timeout_caps_s[pptx_to_pdf_total=%d,pdf_to_images_total=%d]",
+            session.conversion_id,
+            session.source_filename,
+            self._config.conversion_image_dpi,
+            self._config.conversion_pptx_to_pdf_timeout_seconds,
+            self._config.conversion_pdf_to_images_timeout_seconds,
+        )
         work_dir = Path(
             tempfile.mkdtemp(prefix=f"officeconvert-{session.conversion_id}-")
         ).resolve()
@@ -230,17 +245,52 @@ class ConversionServiceImpl(conversion_connect.ConversionService):
             session.status = conversion_pb2.CONVERSION_STATUS_SUCCEEDED
             session.phase = conversion_pb2.CONVERSION_PHASE_INACTIVE
             session.updated_at = utc_now()
+            elapsed_s = time.monotonic() - started_at
+            logger.info(
+                "Conversion succeeded conversion_id=%s source_filename=%s slides=%d elapsed_s=%.3f",
+                session.conversion_id,
+                session.source_filename,
+                len(result.slides),
+                elapsed_s,
+            )
         except asyncio.CancelledError:
             session.status = conversion_pb2.CONVERSION_STATUS_FAILED
             session.phase = conversion_pb2.CONVERSION_PHASE_INACTIVE
             session.error_message = "conversion cancelled"
             session.updated_at = utc_now()
+            elapsed_s = time.monotonic() - started_at
+            logger.warning(
+                "Conversion cancelled conversion_id=%s source_filename=%s elapsed_s=%.3f",
+                session.conversion_id,
+                session.source_filename,
+                elapsed_s,
+            )
             raise
+        except ConversionTimeoutError as exc:
+            session.status = conversion_pb2.CONVERSION_STATUS_FAILED
+            session.phase = conversion_pb2.CONVERSION_PHASE_INACTIVE
+            session.error_message = str(exc)
+            session.updated_at = utc_now()
+            elapsed_s = time.monotonic() - started_at
+            logger.error(
+                "Conversion timed out conversion_id=%s source_filename=%s elapsed_s=%.3f error=%s",
+                session.conversion_id,
+                session.source_filename,
+                elapsed_s,
+                exc,
+            )
         except Exception as exc:
             session.status = conversion_pb2.CONVERSION_STATUS_FAILED
             session.phase = conversion_pb2.CONVERSION_PHASE_INACTIVE
             session.error_message = str(exc)
             session.updated_at = utc_now()
+            elapsed_s = time.monotonic() - started_at
+            logger.exception(
+                "Conversion failed conversion_id=%s source_filename=%s elapsed_s=%.3f",
+                session.conversion_id,
+                session.source_filename,
+                elapsed_s,
+            )
         finally:
             await self._cleanup_local_artifacts(session)
             session.cleanup_task = asyncio.create_task(self._delayed_cleanup(session))